[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

Bill Wendling via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 24 11:13:04 PDT 2022


void added inline comments.


================
Comment at: clang/include/clang/Basic/LangOptions.h:60
 ///  static_asserts in Triple.cpp and in clang/Basic/HLSLRuntime.h.
 enum class ShaderStage {
   Pixel = 0,
----------------
serge-sans-paille wrote:
> Looks unrelated to this patch :-)
I don't see a change here.


================
Comment at: clang/include/clang/Basic/LangOptions.h:231
     ///   - Reverse the implementation for DR692, DR1395 and DR1432.
     ///   - pack non-POD members of packed structs.
     Ver15,
----------------
serge-sans-paille wrote:
> Looks unrelated to this patch.
Or here.


================
Comment at: clang/lib/AST/ExprConstant.cpp:14085
     return true;
   }
   }
----------------
serge-sans-paille wrote:
> fascinatingly off topic. But gives a good hint on what you're working on ;-) 
I'm not sure what you mean.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134902/new/

https://reviews.llvm.org/D134902



More information about the cfe-commits mailing list