[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 24 09:57:12 PDT 2022


nickdesaulniers added inline comments.


================
Comment at: clang/CMakeLists.txt:6
 if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
+  # Please keep policies in sync with llvm/CMakeLists.txt.
+  if(POLICY CMP0114)
----------------
Seems error prone. Does cmake have an include system for including fragments from elsewhere? If so, that seems like a more concise and less error prone approach.

https://cmake.org/cmake/help/latest/command/include.html


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136572/new/

https://reviews.llvm.org/D136572



More information about the cfe-commits mailing list