[PATCH] D136423: [clang][Interp] Implement inc/dec postfix and prefix operators

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 24 08:17:34 PDT 2022


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from nits.



================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1275-1277
+    if (DiscardResult)
+      return this->emitPop(*T, E);
     return this->emitInvBool(E);
----------------



================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1281-1283
+    if (DiscardResult)
+      return this->emitPop(*T, E);
+    return this->emitNeg(*T, E);
----------------



================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1287-1289
+    if (DiscardResult)
+      return this->emitPop(*T, E);
+    return true;
----------------



================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1294-1296
+    if (DiscardResult)
+      return this->emitPop(*T, E);
+    return true;
----------------



================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1310-1312
+    if (DiscardResult)
+      return this->emitPop(*T, E);
+    return this->emitComp(*T, E);
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136423/new/

https://reviews.llvm.org/D136423



More information about the cfe-commits mailing list