[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 24 06:42:29 PDT 2022
erichkeane added inline comments.
================
Comment at: clang/lib/Sema/SemaConcept.cpp:1079
MultiLevelTemplateArgumentList MLTAL = S.getTemplateInstantiationArgs(
- CSE->getNamedConcept(), /*Final=*/false, &TAL,
+ CSE->getNamedConcept(), /*Final=*/true, &TAL,
/*RelativeToPrimary=*/true,
----------------
mizvekov wrote:
> erichkeane wrote:
> > Comment here should be "RelativeToPrimary=" I think.
> This is a new parameter introduced in D134604, you would have to read that dependency first to figure that out :)
> I forgot to mention that on the description of this patch.
Ah!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136566/new/
https://reviews.llvm.org/D136566
More information about the cfe-commits
mailing list