[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 24 06:26:22 PDT 2022


erichkeane accepted this revision.
erichkeane added inline comments.


================
Comment at: clang/lib/Sema/SemaDecl.cpp:176
+  auto *FoundRD = dyn_cast<CXXRecordDecl>(TD);
+  if (DCK != DiagCtorKind::None && LookupRD && FoundRD &&
+      FoundRD->isInjectedClassName() &&
----------------
So I know our coding standard is a little awkward here, but I'd prefer curley braces here.  I think the 'size' of the Diag line here qualifies as 'multiple lines'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136533/new/

https://reviews.llvm.org/D136533



More information about the cfe-commits mailing list