[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

[Erich Keane via Phabricator via cfe-commits]

erichkeane accepted this revision.
erichkeane added inline comments.


================
Comment at: clang/test/CXX/over/over.match/over.match.best/p2.cpp:10
   };
-  bool k1 = A<int>() < A<int>(); // not ordered by constraints: prefer non-rewritten form
-  bool k2 = A<float>() < A<float>(); // prefer more-constrained 'operator<=>'
----------------
ychen wrote:
> Remove this case because it compiles by accident. https://eel.is/c++draft/over.match#best.general-2.6 take precedence over https://eel.is/c++draft/over.match#best.general-2.8.
Could you instead replace it with a better comment + a 'fixme' or something if we need to fix it in the future?  I don't want to lose the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136545/new/

https://reviews.llvm.org/D136545