[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

[Dave Green via Phabricator via cfe-commits]

dmgreen added reviewers: lenary, dmgreen.
dmgreen added inline comments.


================
Comment at: clang/docs/ReleaseNotes.rst:397
   configuration files.
+- Support has been added for the following processors (-mcpu identifiers in parentheses):
+
----------------
This should be in the "Arm and AArch64 Support in Clang" section.


================
Comment at: llvm/docs/ReleaseNotes.rst:84
 
+* Added support for the Cortex-X3 CPU.
+
----------------
Can you add a reference to neoverse-v2 too.


================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:220
                   AArch64::AEK_FP16FML))
+AARCH64_CPU_NAME("cortex-x3",           ARMV9A, FK_CRYPTO_NEON_FP_ARMV8, false,
+                 (AArch64::AEK_SVE | AArch64::AEK_PERFMON | AArch64::AEK_PROFILE |
----------------
Remove this space
I believe Crypto should be removed.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:791
+                               FeaturePostRAScheduler,
+                               FeatureFuseAES]>;
+
----------------
Please add FeatureFuseAdrpAdd and FeatureLSLFast.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136589/new/

https://reviews.llvm.org/D136589