[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 24 02:53:07 PDT 2022


kadircet added a comment.

In D135953#3861180 <https://reviews.llvm.org/D135953#3861180>, @tschuett wrote:

> We support Apple Clang 9.3, but `std:variant` ships with Apple Clang 10.0. :-(

Hi @tschuett, there are other pieces of LLVM that use `<variant>` today already, some big components include TableGen, DenseMap, CodeGen, flang, pseudo, MLIR. so i guess LLVM is already non-compilable today on apple clang 9.3 and someone needs to do a cleanup (i am happy to drop the usage here and in my other patches, but it won't prevent others from introducing more usage, so I don't see how useful my changes here would be)

I've brought this up in https://discourse.llvm.org/t/important-new-toolchain-requirements-to-build-llvm-will-most-likely-be-landing-within-a-week-prepare-your-buildbots/61447/12?u=kadircet. Please pile up on that thread if you're a maintainer for that particular toolchain, rather than just a concerned citizen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135953/new/

https://reviews.llvm.org/D135953



More information about the cfe-commits mailing list