[PATCH] D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking.
Petr Hosek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Oct 23 14:55:48 PDT 2022
phosek added a comment.
I wasn't included as a reviewer on D124857 <https://reviews.llvm.org/D124857> and I missed that change so couldn't comment there, but I'm not a fan of including the AIX support in `InstrProfilingPlatformLinux.c`. AIX is neither Linux nor ELF-based and big chunks of that file are now `#ifdef`ed out making it harder to comprehend which part is used where. I'd prefer introducing `InstrProfilingPlatformAIX.c`, moving the AIX-specific logic there, and then figuring out how to possibly share common parts between `InstrProfilingPlatformLinux.c` and `InstrProfilingPlatformAIX.c`, for example by moving them to an `.inc` file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136192/new/
https://reviews.llvm.org/D136192
More information about the cfe-commits
mailing list