[PATCH] D136539: [Lex] Bring back the magic number 50 in updateConsecutiveMacroArgTokens.

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 23 13:56:50 PDT 2022


alexfh added a comment.

In D136539#3877872 <https://reviews.llvm.org/D136539#3877872>, @sammccall wrote:

> This is a subtle change that needs careful review, and honestly should have a test.
>
> I realize there's a breakage that needs to be fixed with some urgency and you believe you're just restoring the old behavior, however in that case the right course of action is to revert the patch.

You're right. Let's first revert the change that caused the problem and then figure out what amount of testing is necessary here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136539/new/

https://reviews.llvm.org/D136539



More information about the cfe-commits mailing list