[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access
Yuanfang Chen via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Oct 23 11:35:46 PDT 2022
ychen added a comment.
Looks straightforward to me with one suggestion.
Is the CI fail related?
================
Comment at: clang/include/clang/Sema/Sema.h:2569
+ enum class TypeAccessKind { Explicit, Implicit, Typename };
+ QualType getTypeDeclType(DeclContext *LookupCtx, TypeAccessKind AK,
----------------
I find it hard to understand this enum since it does not correlate with wordings well and need to read code in other places to understand what it is used for. How about using two parameters: `bool DiagCtor` (replace `AK != TypeAccessKind::Explicit`) and `bool IsImplicitTypename` (replace `AK == TypeAccessKind::Typename`) ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136533/new/
https://reviews.llvm.org/D136533
More information about the cfe-commits
mailing list