[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

Sat Oct 22 08:55:58 PDT 2022

calebzulawski added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2120
+    Optional<StringRef> SDKName = None;
+    if (getTriple().isWatchOS()) {
+      if (getTriple().isSimulatorEnvironment())
----------------
tschuett wrote:
> Will there be an enum over the Apple variants to make this less error prone and future proof? I want a switch statement.
It doesn't look like there is any enum available that _only_ contains Apple OS variants, but I did change this to a switch-case over the OS in general.  Also, I noticed I missed DriverKit, so I added it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136315/new/

https://reviews.llvm.org/D136315