[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

Thorsten via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 22 08:15:21 PDT 2022


tschuett added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2120
+    Optional<StringRef> SDKName = None;
+    if (getTriple().isWatchOS()) {
+      if (getTriple().isSimulatorEnvironment())
----------------
Will there be an enum over the Apple variants to make this less error prone and future proof? I want a switch statement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136315/new/

https://reviews.llvm.org/D136315



More information about the cfe-commits mailing list