[PATCH] D136449: [Clang] Implement P2513

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 21 10:03:36 PDT 2022


cor3ntin added a comment.

In D136449#3874867 <https://reviews.llvm.org/D136449#3874867>, @aaron.ballman wrote:

> Thanks for this! Can you add more details to the patch summary as to what this paper does? Paper numbers help, but don't convey a whole lot of information at a glance if we need to come back to this review for code archeology.
>
> Please also add a test to the correct file in clang/test/CXX/drs/ and regenerate our C++ DR status page.

I'll check but i don't think we have a number of that, we just decided to backport the paper

> Are we missing changes for "with an integral conversion [conv.integral] if necessary for the source and destination value." ?

Nope, that's taken care of afaict, I'm trying to think of a test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136449/new/

https://reviews.llvm.org/D136449



More information about the cfe-commits mailing list