[PATCH] D136424: Update links to googletest documentation

Jan Kasper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 21 00:33:12 PDT 2022


DerKasper created this revision.
DerKasper added a reviewer: njames93.
DerKasper added a project: clang-tools-extra.
Herald added a subscriber: carlosgalvezp.
Herald added a project: All.
DerKasper requested review of this revision.
Herald added a subscriber: cfe-commits.

Update links to googletest documentation
No automatic tests, but local manual test: i click it, it opens the googletest documentation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D136424

Files:
  clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.h
  clang-tools-extra/docs/clang-tidy/checks/google/readability-avoid-underscore-in-googletest-name.rst


Index: clang-tools-extra/docs/clang-tidy/checks/google/readability-avoid-underscore-in-googletest-name.rst
===================================================================
--- clang-tools-extra/docs/clang-tidy/checks/google/readability-avoid-underscore-in-googletest-name.rst
+++ clang-tools-extra/docs/clang-tidy/checks/google/readability-avoid-underscore-in-googletest-name.rst
@@ -30,5 +30,5 @@
 
 This check does not propose any fixes.
 
-.. _Underscores are not allowed: https://github.com/google/googletest/blob/master/googletest/docs/faq.md#why-should-test-suite-names-and-test-names-not-contain-underscore
-.. _disable individual tests: https://github.com/google/googletest/blob/master/googletest/docs/faq.md#why-should-test-suite-names-and-test-names-not-contain-underscore
+.. _Underscores are not allowed: https://google.github.io/googletest/faq.html#why-should-test-suite-names-and-test-names-not-contain-underscore
+.. _disable individual tests: https://google.github.io/googletest/advanced.html#temporarily-disabling-tests
Index: clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.h
===================================================================
--- clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.h
+++ clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.h
@@ -17,7 +17,7 @@
 namespace readability {
 
 // Check for underscores in the names of googletest tests, per
-// https://github.com/google/googletest/blob/master/docs/faq.md#why-should-test-suite-names-and-test-names-not-contain-underscore
+// https://google.github.io/googletest/faq.html#why-should-test-suite-names-and-test-names-not-contain-underscore
 ///
 /// For the user-facing documentation see:
 /// http://clang.llvm.org/extra/clang-tidy/checks/google/readability-avoid-underscore-in-googletest-name.html


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136424.469488.patch
Type: text/x-patch
Size: 1863 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221021/b90f350a/attachment.bin>


More information about the cfe-commits mailing list