[PATCH] D135937: [WIP][X86] Support -march=raptorlake, meteorlake

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 20 23:07:25 PDT 2022


MaskRay added inline comments.


================
Comment at: clang/test/Driver/x86-march.c:120
+// RUN:   | FileCheck %s -check-prefix=meteorlake
+// meteorlake: "-target-cpu" "meteorlake"
 //
----------------
RKSimon wrote:
> Move these after alderlake instead of the old atom cores?
And use `--target=` for new tests. `-target ` is legacy.


================
Comment at: compiler-rt/lib/builtins/cpu_model.c:478
+      *Type = INTEL_COREI7;
+      *Subtype = INTEL_COREI7_METEORLAKE;
+
----------------
fallthrough?


================
Comment at: llvm/docs/ReleaseNotes.rst:133
 --------------------------
+- Support ``-mcpu=raptorlake``
+- Support ``-mcpu=meteorlake``
----------------
-mcpu=xxx and -mcpu=yyy are now supported.


================
Comment at: llvm/lib/Support/Host.cpp:836
+      *Type = X86::INTEL_COREI7;
+      *Subtype = X86::INTEL_COREI7_METEORLAKE;
+
----------------
fallthrough?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135937/new/

https://reviews.llvm.org/D135937



More information about the cfe-commits mailing list