[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

Thu Oct 20 09:40:52 PDT 2022

qiongsiwu1 added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4374
+                              ? llvm::DebuggerKind::Default
+                              : DebuggerTuning);

----------------
probinson wrote:
> Seems like you should be able to return `DebuggerKind::Default` from `getDefaultDebuggerTuning` then you wouldn't need this complication?
Ah thanks for the suggestion! 

We looked into an approach along this line in an earlier version (see https://reviews.llvm.org/D136187?id=468626), but it seemed that modifying the AIX default was not ideal. There are two drawbacks. 

1. It complicates [[ https://github.com/llvm/llvm-project/blob/7e04c0ad632527df0a4c4d34a6ac6ec6a3888dfe/clang/lib/Driver/ToolChains/Clang.cpp#L4267 | setting ]] `gstrict-dwarf` and [[ https://github.com/llvm/llvm-project/blob/7e04c0ad632527df0a4c4d34a6ac6ec6a3888dfe/clang/lib/Driver/ToolChains/Clang.cpp#L4284 | setting ]] `gno-column-info`. The earlier version had to revise those conditions.
2. It may complicate future development that relies on the AIX tuning defaulting to DBX. 

Therefore we ended up with this local change. That said, I am all ears for different ways to avoid the complication. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136187/new/

https://reviews.llvm.org/D136187