[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added a comment.

@MaskRay do you think I should make it so that `-g -g0` disables passing through `-g`?



================
Comment at: clang/test/Driver/as-options.s:120
+
+// Test that -g is passed through to GAS.
+// RUN: %clang -fno-integrated-as -g %s -### 2>&1 | \
----------------
MaskRay wrote:
> -g can be tested along with other pass-through options. This way we test the relative order (though usually it doesn't matter but it improves the check) and decreases the number of clang invocations.
Is the suggestion to:
1. combine this test with a pre-existing RUN line? or
2. Test all of the pass through options in this run line.

If 1, then I'm not sure which test best to combine this with.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136309/new/

https://reviews.llvm.org/D136309