[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

Thu Oct 20 05:28:55 PDT 2022

ldionne added a comment.

Thanks for picking this up! I looked at my local changes and I had started modifying `inferDeploymentTargetFromSDK`. I had left the comment:

  /// TODO: We should only infer it if the SDK was provided with SDKROOT or -isysroot.
  ///       If we inferred the SDK with xcrun, it doesn't make sense to infer the
  ///       deployment target because <REASONS>

I don't remember what I was thinking at the time, but I encourage you to pause for a minute and think about it. I can't think of the reason anymore. If you cant' either, maybe just disregard my comment entirely.

================
Comment at: clang/test/Driver/darwin-sdkroot.c:43-44

+// Check that we default to running `xcrun --show-sdk-path` if there is no
+// SDKROOT defined in the environment.
+//
----------------
You should test with multiple target triples if that's possible.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136315/new/

https://reviews.llvm.org/D136315