[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

[Phoebe Wang via Phabricator via cfe-commits]

pengfei added inline comments.


================
Comment at: clang/lib/Headers/CMakeLists.txt:146
   avxvnniintrin.h
+  avxvnniint8intrin.h
   bmi2intrin.h
----------------
Move it before `avxvnniintrin.h` for the order?


================
Comment at: llvm/lib/Support/X86TargetParser.cpp:584
 
+static constexpr FeatureBitset ImpliedFeaturesAVXVNNIINT8 = FeatureAVX2;
 static constexpr FeatureBitset ImpliedFeaturesAVX512FP16 =
----------------
This is redundant, I have fixed `ImpliedFeaturesAVX512FP16` in trunk code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135938/new/

https://reviews.llvm.org/D135938