[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

Juergen Ributzka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 19 17:37:20 PDT 2022


ributzka added inline comments.


================
Comment at: clang/test/Modules/file-manager-lookup-count.m:73
+// RUN: FileCheck --input-file %t/stats %s
+// CHECK:      {
+// CHECK-NEXT:   "file-search.NumDirCacheMisses": 156,
----------------
The content of the stats file may change over time, so the test shouldn't limit it to just the listed entries. I would drop the first and last `CHECK` and change `CHECK-NEXT` to just `CHECK`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136019/new/

https://reviews.llvm.org/D136019



More information about the cfe-commits mailing list