[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

[Eduard Zingerman via Phabricator via cfe-commits]

eddyz87 marked 2 inline comments as done.
eddyz87 added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:3473
       !Call.getCalledFunction()->isInterposable() &&
+      !Call.getCalledFunction()->isDeclaration() &&
       Call.getCalledFunction()->getSubprogram())
----------------
MaskRay wrote:
> Removing this check does not break any `check-llvm check-clang` test.
Well, that's embarrassing, thank you for catching it!
I've updated `llvm/test/Verifier/callsite-dbgloc.ll` by adding `!dbg` metadata for `@i`. Know the test fails if the check above is commented out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136041/new/

https://reviews.llvm.org/D136041