[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 19 07:47:32 PDT 2022


beanz added a comment.

In addition to restoring the test cases that you deleted, I think you should also reduce and simplify the test cases you're adding. These new tests are very large blobs of IR generated by clang. They include a lot of extra instructions that aren't needed to exercise the code you wrote in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135429/new/

https://reviews.llvm.org/D135429



More information about the cfe-commits mailing list