[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

ChenZheng via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 18 17:55:50 PDT 2022


shchenz added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AIX.h:91
   llvm::DebuggerKind getDefaultDebuggerTuning() const override {
-    return llvm::DebuggerKind::DBX;
+    return llvm::DebuggerKind::Default;
   }
----------------
This sounds not right. Omitting `-debugger-tuning=dbx` does not mean we will change the default tuning  debugger on AIX, right? i.e. DBX is still the default debugger on AIX no matter in the clang fe or llvm be.

We should just be able to do some customization when we call `RenderDebugEnablingArgs` for AIX in https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Clang.cpp#L4367-L4368


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136187/new/

https://reviews.llvm.org/D136187



More information about the cfe-commits mailing list