[PATCH] D136188: Update docs for -fuse-ctor-homing

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 18 15:20:09 PDT 2022


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good to me with the addition of the forth homing strategy.

In D136188#3866494 <https://reviews.llvm.org/D136188#3866494>, @probinson wrote:

> +jmorse who is closer to this topic than I am.
>
> We've had a few complaints from licensees about ctor homing, and debug-info size in general is something of a sensitive topic.  But if we can come to a place where `-fstandalone-debug` is an acceptable fallback, I can live with that.

Sounds good (`-fstandalone-debug` is a pretty big size regression, though, which makes it difficult to swallow) - sorry, didn't mean to derail this review, I should go pick this up again on whatever review I was proposing removing the ctor homing flags/fully rolling it into no-standalone-debug...



================
Comment at: clang/docs/UsersManual.rst:2845-2850
+- Clang will not emit type definitions for types that are not needed by a
+  module and could be replaced with a forward declaration.
+- Clang will only emit type info for a dynamic C++ class in the module that
+  contains the vtable for the class.
+- Clang will only emit type info for a C++ class (non-trivial, non-aggregate)
+  in the modules that contain a definition for one of its constructors.
----------------
There's a forth strategy - clang will emit type definitions for types that are the subject of a explicit template instantiation declarations only in the presence of an explicit instantiation definition for the type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136188/new/

https://reviews.llvm.org/D136188



More information about the cfe-commits mailing list