[PATCH] D136198: [OpenMP] Make kernels have protected visibility

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 18 13:07:38 PDT 2022


jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, ABataev, JonChesterfield, tianshilei1992, ronlieb.
Herald added subscribers: kosarev, mattd, asavonic, guansong, yaxunl, jvesely.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.

This patch changes the kernels generated by OpenMP to have protected
visibility. This is unlikely to change anything functionally. However,
protected visibility better matches the behaviour of these GPU kernels.
We do not expect any pending shared library load to preempt these
kernels so we can specify a more restrictive visibility.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D136198

Files:
  clang/lib/CodeGen/CGOpenMPRuntime.cpp
  clang/test/OpenMP/amdgcn_target_codegen.cpp
  clang/test/OpenMP/assumes_include_nvptx.cpp
  clang/test/OpenMP/declare_target_codegen.cpp
  clang/test/OpenMP/declare_target_link_codegen.cpp
  clang/test/OpenMP/metadirective_device_arch_codegen.cpp
  clang/test/OpenMP/metadirective_device_isa_codegen_amdgcn.cpp
  clang/test/OpenMP/nvptx_declare_target_var_ctor_dtor_codegen.cpp
  clang/test/OpenMP/nvptx_target_firstprivate_codegen.cpp
  clang/test/OpenMP/target_firstprivate_codegen.cpp
  clang/test/OpenMP/target_private_codegen.cpp
  clang/test/OpenMP/target_reduction_codegen.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136198.468673.patch
Type: text/x-patch
Size: 18856 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221018/89fd45d6/attachment-0001.bin>


More information about the cfe-commits mailing list