[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

Tue Oct 18 10:58:25 PDT 2022

thesamesam added a comment.

In D134337#3865905 <https://reviews.llvm.org/D134337#3865905>, @tstellar wrote:

> In D134337#3865753 <https://reviews.llvm.org/D134337#3865753>, @mgorny wrote:
>
>> In D134337#3865541 <https://reviews.llvm.org/D134337#3865541>, @tstellar wrote:
>>
>>> I know I'm a little late here, but having a default config file that's always loaded makes triaging issues much harder, because now every time someone files a bug, we need to ask for the contents of their config directory.
>>
>> I don't see that as much worse than asking them for the values of `*DEFAULT*` CMake options or whether they have patched their clang because the driver code makes so many specific assumptions that it didn't work for them. At least `clang -v` tells us whether they are actually using any configs.
>
> At least as a distro maintainer, I know the CMake options used for the packages I'm trying to support.
>
> I was also wondering, would it be possible to move some of the targets specific driver code out of the codebase and into config files that are shipped with clang?

We covered the need for this, I feel, quite extensively in the linked discussions - especially wrt the Clang 15/16 -Werror changes.

As for bug reports: just ask people to use --no-default-config if something looks dodgy?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134337/new/

https://reviews.llvm.org/D134337