[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir added a comment.

(catching up after I was away last week) I agree with @dexonsmith's analysis above. One historical note:

> As a heuristic on top of (4), "last-ref" (before this patch) probably gets the answer the user expects more often than "first-ref" (this patch) does, which I assume is why it was originally implemented.

It was originally implemented this way because it works out more often for module-related files, and vfs overlays; debug info and preprocessor output of this kind was not considered. This is part of a workaround for lack of proper FileEntryRef support across the compiler that we should unwind over time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135220/new/

https://reviews.llvm.org/D135220