[PATCH] D136124: [clang][deps] Remove unintentional `move`

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 18 08:14:58 PDT 2022


jansvoboda11 added inline comments.


================
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:400
+    auto OverlayFS =
+        llvm::makeIntrusiveRefCnt<llvm::vfs::OverlayFileSystem>(BaseFS);
     auto InMemoryFS =
----------------
DavidSpickett wrote:
> Is this equivalent?
> ```
> auto OverlayFS = BaseFS;
> ```
> Given that BaseFS is already `IntrusiveRefCntPtr`.
It's not, because `BaseFS` is pointer to the `llvm::vfs::FileSystem` interface. Here we need to call members of `llvm::vfs::OverlayFileSystem` specifically.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136124/new/

https://reviews.llvm.org/D136124



More information about the cfe-commits mailing list