[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

Jordan Rupprecht via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 18 08:12:34 PDT 2022


rupprecht added a comment.

I'm seeing a fair number of breakages from this patch (not really sure how many we truly have, I've hit ~5-10 so far in widely used libraries, but I suspect we have far more in the long tail). They're all valid (most are just adding missing thread safety annotations, etc., so far one breakage caught a real bug), but it would help if we could disable just these new ones. How invasive/annoying would it be to carve out a subwarning for this category of bugs and call it something like `-Wthread-safety-elision`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129755/new/

https://reviews.llvm.org/D129755



More information about the cfe-commits mailing list