[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 18 06:03:30 PDT 2022


erichkeane added a comment.

Thank you so much for doing this.  I'm hopeful our hackery can go away sometime soon.



================
Comment at: clang/test/CXX/drs/dr25xx.cpp:3
 
-namespace dr2565 { // dr252: 16
+namespace dr2565 { // dr2565: partial
   template<typename T>
----------------
If you could add a comment explaining this status for me, I would be grateful:

// We've implemented DR2565 as proposed (that is, a substitution failure in a requires parameter list causes the requires clause to evaluate as false) as it seems to make the most sense, and fit best into our implementation. If this issue gets accepted as-is, this can be marked as complete.


================
Comment at: clang/www/make_cxx_dr_status:161
     continue
-  if dr.status in ('open', 'concurrency', 'drafting', 'review', 'extension'):
+  if dr.issue in (1432,2565):
+    row_style = ' class="open"'
----------------
I guess this is OK, its a shame we have to custom-tag these, but I guess I'm 1/2 responsible here :/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136133/new/

https://reviews.llvm.org/D136133



More information about the cfe-commits mailing list