[PATCH] D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__

[Ties Stuij via Phabricator via cfe-commits]

stuij marked an inline comment as done.
stuij added inline comments.


================
Comment at: clang/test/Preprocessor/init-arm.c:404
+//   is specified
+// RUN: %clang_cc1 -E -dM -ffreestanding -triple=arm-none-linux-gnueabi -target-feature +soft-float -target-feature +soft-float-abi < /dev/null | FileCheck -match-full-lines -check-prefix ARMEABISOFTFP_NOFP %s
 //
----------------
pratlucas wrote:
> I believe this RUN line won't covered the new condition added to `clang/lib/Basic/Targets/ARM.cpp` above, as it sets `+soft-float`.
> Can you add an extra test without that option enabled?
ah yes, thanks! added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135680/new/

https://reviews.llvm.org/D135680