[PATCH] D136080: [flang] Add -ffp-contract option processing

Tue Oct 18 03:58:08 PDT 2022

tblah marked 5 inline comments as done.
tblah added a comment.

Thanks for taking a look. I've updated accordingly and will upload the patch soon.

> are you confident that we will need LangOptions.def?

Clang places this flag (and many other floating point options) in LangOptions so I thought I would follow the same convention here. Is there somewhere more appropriate to put them?

================
Comment at: clang/lib/Driver/ToolChains/Flang.cpp:85-86
+                                    ArgStringList &CmdArgs) {
+  // TODO: share RenderFloatingPointOptions from ./Clang.cpp and use that
+  // instead of duplicating code here
+  StringRef FPContract;
----------------
awarzynski wrote:
> What's RenderFloatingPointOptions?
It is a static function in clang/lib/Driver/ToolChains/Clang.cpp which does the same job as AddFloatingPointOptions, except for clang. I couldn't use it right away because not all of the options it it processes are supported in flang, but once we get there it would make sense to share code.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136080/new/

https://reviews.llvm.org/D136080