[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

Vitaly Buka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 17 14:55:51 PDT 2022


vitalybuka added a comment.





================
Comment at: clang/lib/CodeGen/CGExpr.cpp:1746
 
+  if (auto TyPtr = Ty.getTypePtrOrNull()) {
+    if (!(TyPtr->isSpecificBuiltinType(BuiltinType::UChar) ||
----------------
Taking into account potantial risks from pre-existing UB, I believe we need clang switch to be able to shutdown this branch, similar to enable_noundef_analysis.
User with large code bases maybe need some time for transition.

I have no opinion if this should be ON or OFF by default


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134410/new/

https://reviews.llvm.org/D134410



More information about the cfe-commits mailing list