[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

[Qiongsi Wu via Phabricator via cfe-commits]

qiongsiwu1 marked 3 inline comments as done.
qiongsiwu1 added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:589
+      // On platforms other than AIX, gdb is the default option.
+      // On AIX, dbx will be automatically pick up in the presense of the
+      // debugger tuning argument, so set gdb only if it is specified.
----------------
shchenz wrote:
> Typo: presense -> absence?
Thanks for the catch! I realized the original code was confusing (probably incorrect). The logic is rewritten and the comment is eliminated. 


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:590
+      // On AIX, dbx will be automatically pick up in the presense of the
+      // debugger tuning argument, so set gdb only if it is specified.
+      if (!IsOSAIX || A->getOption().matches(options::OPT_ggdb) ||
----------------
shchenz wrote:
> Could you also post another patch to fix the no-lto path to remove the redundant `-debugger-tuning=dbx` on AIX? We should make the lto mode and non-lto mode be consistent.
Yes will do! 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135908/new/

https://reviews.llvm.org/D135908