[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

Alex Brachet via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 17 13:49:17 PDT 2022


abrachet added a comment.

In D128567#3863178 <https://reviews.llvm.org/D128567#3863178>, @aeubanks wrote:

> I've noticed that we're skipping compiler-rt tests with `REQUIRED: lld-available` because `LLVM_TOOL_LLD_BUILD` needs to be defined. any update on the proposed alternative?

I think the canonical way this is done throughout the code base is with

  from lit.llvm import llvm_config
  
  if llvm_config.use_lld(required=False):
      config.available_features.add('lld')

Though, what I think we don't do currently here or elsewhere is conditionally add test deps on `lld` if it is specified in `LLVM_ENABLE_PROJECTS`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128567/new/

https://reviews.llvm.org/D128567



More information about the cfe-commits mailing list