[PATCH] D136106: [clang][RISCV] Set vscale_range attribute based on VLEN

Mon Oct 17 13:45:48 PDT 2022

reames added a comment.

In D136106#3863147 <https://reviews.llvm.org/D136106#3863147>, @craig.topper wrote:

>> In the original review, I'd mentioned that MinVLEN was sometimes zero. That's still true, but apparently only happens if you specify multiple extensions in the -target_feature string. So, we can at least test "v" and "zve64x" on their own before I go figure out exactly what's going wrong regarding e.g. parsing "+v,+zvl512b".
>
> I think you need to use `-target-feature "v" -target-feature "zvl512b".

So, this was part right.  The other issue is I'd been using Zvl512b, and apparently this bit of parsing code is case sensitive.  I'm going to look into improving the error reporting here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136106/new/

https://reviews.llvm.org/D136106