[PATCH] D134507: [Clang] add missing ClangABICompat check

Yuanfang Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 17 12:31:33 PDT 2022


ychen added a comment.

In D134507#3856956 <https://reviews.llvm.org/D134507#3856956>, @tahonermann wrote:

>> Per further discussions in D128745 <https://reviews.llvm.org/D128745>, this is not needed.
>
> I agree that the code change is not needed. I think it is worth keeping the test though (modified to verify the expected ambiguity).

Agreed. It turns out the ambiguous case is already in place. (https://github.com/llvm/llvm-project/blob/d8af31ecede0c54ec667ab687784149e806c9e4c/clang/test/CXX/drs/dr6xx.cpp#L1104)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134507/new/

https://reviews.llvm.org/D134507



More information about the cfe-commits mailing list