[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:17398-17399
+      const bool IsDiscardMisalignedPointer =
+          T->isPointerType() &&
+          (T->getPointeeType()->isIncompleteType() || T->isDependentType() ||
+           Context.getTypeAlignInChars(T->getPointeeType()) <= MA->Alignment);
----------------
shafik wrote:
> aaron.ballman wrote:
> > Hmm, is this logic correct? Don't we want:
> > 
> > ```
> > T->isDependentType() ||
> >   (T->isPointerType() &&
> >     (T->getPointeeType()->isIncompleteType() || Context.getTypeAlignInChars(T->getPointeeType()) <= MA->Alignment))
> > ```
> Why did you drop the `T->isIntegerType()`?
Whoops! That's totally a typo on my part, I didn't intend to drop it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136018/new/

https://reviews.llvm.org/D136018