[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

Mon Oct 17 03:28:15 PDT 2022

domada marked 2 inline comments as done.
domada added inline comments.

================
Comment at: clang/test/OpenMP/irbuilder_simd_aligned.cpp:69
+// CHECK:       omp_loop.preheader:
+// CHECK-COUNT-3: call void @llvm.assume(i1 true) [ "align"
+// CHECK-NEXT:    br label [[OMP_LOOP_HEADER:%.*]]
----------------
jdoerfert wrote:
> Did you not check the alignment here on purpose? I'd assume this is the most important line in the test, no? Also, consider this cannot be auto-updated anymore w/o loosing manual updates.
Yes, I replaced CHECK-NEXT by CHECK-COUNT because DenseMap does not provide reproducible order of iteration and we cannot assume that llvm.assume calls will be done in given order.

I decided to replace DenseMap with MapVector as the follow-up after your review. MapVector provides access to stored elements in deterministic order and we can rely on generated checks. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133578/new/

https://reviews.llvm.org/D133578