[PATCH] D135964: [clang][dataflow] Add equivalence relation for `Value` type.

[Stanislav Gatev via Phabricator via cfe-commits]

sgatev accepted this revision.
sgatev added inline comments.


================
Comment at: clang/lib/Analysis/FlowSensitive/Value.cpp:15
+#include "llvm/Support/Casting.h"
+#include <cassert>
+
----------------
This seems unnecessary.


================
Comment at: clang/unittests/Analysis/FlowSensitive/ValueTest.cpp:30
+  EXPECT_TRUE(areEquivalentValues(V1, V2));
+  // Symmetry.
+  EXPECT_TRUE(areEquivalentValues(V2, V1));
----------------
I suggest dropping the symmetry comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135964/new/

https://reviews.llvm.org/D135964