[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

[Serge Pavlov via Phabricator via cfe-commits]

sepavloff added inline comments.


================
Comment at: llvm/include/llvm/Support/CommandLine.h:2138
+  /// directories specified by SearchDirs field.
+  bool findConfigFile(StringRef FileName, std::string &FilePath);
+
----------------
mgorny wrote:
> I'm sorry if I'm missing something obvious but is there a specific reason you're using `std::string` here when pretty much all prior call sites were using `SmallString`?
Changed type of this parameter to base of `SmallString`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135439/new/

https://reviews.llvm.org/D135439