[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC
Michał Górny via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Oct 16 11:48:58 PDT 2022
mgorny added inline comments.
================
Comment at: llvm/include/llvm/Support/CommandLine.h:2138
+ /// directories specified by SearchDirs field.
+ bool findConfigFile(StringRef FileName, std::string &FilePath);
+
----------------
I'm sorry if I'm missing something obvious but is there a specific reason you're using `std::string` here when pretty much all prior call sites were using `SmallString`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135439/new/
https://reviews.llvm.org/D135439
More information about the cfe-commits
mailing list