[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping
Thorsten via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Oct 16 11:47:12 PDT 2022
tschuett added inline comments.
================
Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:64
+using SymbolLocation = std::variant<SourceLocation, tooling::stdlib::Symbol>;
+/// A set of locations that provides the declaration, while indicating if
----------------
sammccall wrote:
> This is an important public API concept ==> It should be documented and part of a public header, I think
IIRC, the supported Apple Clang does not support `std::variant` yet.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135953/new/
https://reviews.llvm.org/D135953
More information about the cfe-commits
mailing list