[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 15 09:56:53 PDT 2022


vsapsai added a comment.

The change looks good to me. And based on the scope of D121685 <https://reviews.llvm.org/D121685> it should be sufficient. Do you have any ideas for testing? If it would require significant testing infrastructure work, we can do that separately. But if you have some simple testing ideas in mind, that would be worth adding.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136019/new/

https://reviews.llvm.org/D136019



More information about the cfe-commits mailing list