[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

Fri Oct 14 20:29:19 PDT 2022

owenpan added a comment.

In D135707#3858097 <https://reviews.llvm.org/D135707#3858097>, @MyDeveloperDay wrote:

> Thanks @rymiel its great to have another active contributor, especially one who seems so focused on github issues. Really appreciate your recent contributions. Can we start including you as one of the default reviewers that we use to review our stuff?

+1.

In D135707#3859357 <https://reviews.llvm.org/D135707#3859357>, @rymiel wrote:

> I don't *yet* trust myself to actually perform good code review, as it's not something I've really ever done before.

IMO none of us can claim to be an expert in every area of clang-format. :) Even if you don't feel that you are an "expert" yet, you are still encouraged to review code. See here <https://llvm.org/docs/CodeReview.html#who-can-should-review-code> for the rationale.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135707/new/

https://reviews.llvm.org/D135707