[PATCH] D135989: [clang][Sema] Use size of char for void types

Bill Wendling via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 14 14:46:39 PDT 2022


void added a comment.

In D135989#3859763 <https://reviews.llvm.org/D135989#3859763>, @nickdesaulniers wrote:

> LGTM; please consider appending to the commit message something along the lines of "operations on the result of getTypeSize() are in bits, not bytes.  Using 1 as the value for void* is the correct number of bytes, but we're doing arithmetic in bits." or something to denote this is a unit-of-measure related bug.

Done. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135989/new/

https://reviews.llvm.org/D135989



More information about the cfe-commits mailing list