[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 14 09:38:14 PDT 2022


hubert.reinterpretcast added a comment.

In D135919#3858808 <https://reviews.llvm.org/D135919#3858808>, @rjmccall wrote:

> We can't set the flag if initialization is aborted by an exception, which is not ruled out by the use of thread-unsafe statics.  So this is not a correct change.

@tahonermann, the case from https://github.com/llvm/llvm-project/issues/57828 is not for a block-scope variable, but the case in the patch description //is//...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135919/new/

https://reviews.llvm.org/D135919



More information about the cfe-commits mailing list