[PATCH] D131944: [analyzer] Remove pattern matching of lambda capture initializers

Domján Dániel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 14 09:08:32 PDT 2022


isuckatcs marked an inline comment as done.
isuckatcs added inline comments.


================
Comment at: clang/test/Analysis/lambdas.cpp:226
+  [uniquePtr = MakeUniquePtr()] {}();
+  clang_analyzer_warnIfReached(); // expected-warning{{TRUE}}
+}
----------------
steakhal wrote:
> It should have said `REACHABLE`.
> How does this pass? @isuckatcs 
Oh, it's a nice catch. Yes, it should say `REACHABLE` indeed.

Also it seems we didn't get a failing test case because this statement is not checked at all. It is inside a block that only runs if the standard is at least `c++14`, however the tests are only executed with an `-std=c++11` flag.

I moved these test cases into their own test file in D135965.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131944/new/

https://reviews.llvm.org/D131944



More information about the cfe-commits mailing list