[clang] 41ac5d2 - [clang] Fix a warning

Kazu Hirata via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 14 08:37:10 PDT 2022


Author: Kazu Hirata
Date: 2022-10-14T08:36:59-07:00
New Revision: 41ac5d258da3045c871344400aa9e59640ce76a5

URL: https://github.com/llvm/llvm-project/commit/41ac5d258da3045c871344400aa9e59640ce76a5
DIFF: https://github.com/llvm/llvm-project/commit/41ac5d258da3045c871344400aa9e59640ce76a5.diff

LOG: [clang] Fix a warning

This patch fixes:

  clang/lib/CodeGen/CGCall.cpp:1867:64: error: '&&' within '||'
  [-Werror,-Wlogical-op-parentheses]

Added: 
    

Modified: 
    clang/lib/CodeGen/CGCall.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/CodeGen/CGCall.cpp b/clang/lib/CodeGen/CGCall.cpp
index 146271f1f93a..a59d702faaa2 100644
--- a/clang/lib/CodeGen/CGCall.cpp
+++ b/clang/lib/CodeGen/CGCall.cpp
@@ -1863,9 +1863,9 @@ void CodeGenModule::getDefaultFunctionAttributes(StringRef Name,
     if (LangOpts.ApproxFunc)
       FuncAttrs.addAttribute("approx-func-fp-math", "true");
     if ((LangOpts.FastMath ||
-         !LangOpts.FastMath && LangOpts.AllowFPReassoc && LangOpts.AllowRecip &&
-             !LangOpts.FiniteMathOnly && LangOpts.NoSignedZero &&
-             LangOpts.ApproxFunc) &&
+         (!LangOpts.FastMath && LangOpts.AllowFPReassoc &&
+          LangOpts.AllowRecip && !LangOpts.FiniteMathOnly &&
+          LangOpts.NoSignedZero && LangOpts.ApproxFunc)) &&
         LangOpts.getDefaultFPContractMode() != LangOptions::FPModeKind::FPM_Off)
       FuncAttrs.addAttribute("unsafe-fp-math", "true");
     if (CodeGenOpts.SoftFloat)


        


More information about the cfe-commits mailing list